Work around #3947, #4248, #14073; load our utility code #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please don't merge this yet, I'm going to be re-writing history to get the tests cleaned up. I'm also considering moving all of the Win32 specific stuff into a single shim module so we can easily do spec testing on non-windows platforms. |
Contributor
Author
|
Specs are passing on windows. We'll revisit refactoring out the Win32 specific constants later on. This is ready for review. |
Without this patch the registry module blows up when installed onto a Linux Puppet Master. The utility code and the structure of the types and providers end up requiring win32/registry which will never be present on non-windows systems. In addition, the types and providers mix in module level support code, which does not work because of the following Puppet bugs, all related to our inability to load utility code from the $LOAD_PATH. * https://projects.puppetlabs.com/issues/3947 * https://projects.puppetlabs.com/issues/4248 * https://projects.puppetlabs.com/issues/14073 This has annoyed me enough that I'm going revisit these bugs and the interplay of the modulepath, environments, and $LOAD_PATH.
Contributor
Author
|
@joshcooper |
joshcooper
added a commit
that referenced
this pull request
Apr 26, 2012
…a_master Work around #3947, #4248, #14073; load our utility code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the registry module blows up when installed onto a
Linux Puppet Master. The utility code and the structure of the types
and providers end up requiring win32/registry which will never be
present on non-windows systems. In addition, the types and providers
mix in module level support code, which does not work because of the
following Puppet bugs, all related to our inability to load utility code
from the $LOAD_PATH.
This has annoyed me enough that I'm going revisit these bugs and the
interplay of the modulepath, environments, and $LOAD_PATH.